1700: Refactor and clean up csv import #1765
Conversation
| @@ -0,0 +1,6 @@ | |||
| <component name="InspectionProjectProfileManager"> | |||
There was a problem hiding this comment.
This appeared after setting the eslint configuration in IntelliJ to automatic, I guess we want this project wide then?
| @@ -0,0 +1,7 @@ | |||
| import { ProjectConfig } from '../getProjectConfig' | |||
|
|
|||
| export const getCsvHeaders = (projectConfig: ProjectConfig): string[] => [ | |||
There was a problem hiding this comment.
Do you think this is good naming? Or should we change this to columnNames or similar?
There was a problem hiding this comment.
hm for now i think its okay because it serves this particular purpose and can't be reused that easily. But if we combine name, expiry date and extensions into one array to make it more flexible and to enable better reordering of form fields we might not need to explicitly define here the columns names in the array but just loop through and then we could rename it to getColumnNames
steffenkleinle
force-pushed
the
1700-refactor-csv-import
branch
from
2dfb102
to
1a189de
Compare
steffenkleinle
requested review from
f1sh1918,
ztefanie and
seluianova
as code owners
| @@ -57,7 +64,7 @@ const ImportCardsInput = ({ setCards, lineToCard, headers, isFreinetFormat }: Im | |||
| const lines = content | |||
| .split('\n') | |||
| .filter(line => line.trim().length) | |||
| .map(line => line.split(/,|;/).map(cell => cell.trim())) | |||
| .map(line => line.split(/[,;]/).map(cell => cell.trim())) | |||
There was a problem hiding this comment.
could you explain this change
There was a problem hiding this comment.
same behavior, but better readability and even better performance https://stackoverflow.com/questions/22132450/why-is-a-character-class-faster-than-alternation
| @@ -57,7 +64,7 @@ const ImportCardsInput = ({ setCards, lineToCard, headers, isFreinetFormat }: Im | |||
| const lines = content | |||
| .split('\n') | |||
| .filter(line => line.trim().length) | |||
| .map(line => line.split(/,|;/).map(cell => cell.trim())) | |||
| .map(line => line.split(/[,;]/).map(cell => cell.trim())) | |||
There was a problem hiding this comment.
same behavior, but better readability and even better performance https://stackoverflow.com/questions/22132450/why-is-a-character-class-faster-than-alternation
| @@ -38,19 +41,19 @@ const CardImportTable = ({ headers, cards, cardConfig }: CardImportTableProps): | |||
| key={`${rowIndex}-${columnIndex}`} | |||
| tooltip={!valid ? 'Validierungsfehler' : undefined} | |||
| intent={!valid ? 'danger' : 'none'}> | |||
| <TruncatedFormat2 detectTruncation preformatted> | |||
| <TruncatedFormat detectTruncation preformatted> | |||
Short description
Refactor and clean up csv import to avoid implicit side effects.
Proposed changes
Side effects
Testing
Make sure that both normal and freinet CSV import still works.
Resolved issues
Fixes: #1700