Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Auth #3

Closed
wants to merge 3 commits into from
Closed

Fixed Auth #3

wants to merge 3 commits into from

Conversation

Clifford-Foster
Copy link

Included the ability to respond to Authorization requests. This is necessary when linking accounts from the Alexa Skill.

@digitaldan
Copy link
Owner

Hi Clifford, i was not fully aware of this call as account linking works fine already. According to https://developer.amazon.com/docs/device-apis/alexa-authorization.html this is needed to send events to the Alexa event gateway, are you planning on implementing something like this?

@Clifford-Foster
Copy link
Author

Hi Dan, the account linking wasn't working for me when I implemented it for Australia (in development).

When I tracked it down I noticed that the reply didn't have a header as specified in https://developer.amazon.com/docs/device-apis/alexa-authorization.html . Once I implemented this the Account Linking worked perfectly.

My next challenges are:
(1) I am linking to my own OpenHAB cloud. Currently the url is stored in the .env file. Have you found a way to make this available in a user entered field/setting? I can't find a way to do this.
(2) I have to used basic authentication to my OpenHAB cloud. Where do I stored the secrets so that I can use oauth between the skill and OpenHAB cloud? This will save me tracing through all your code.

Btw - great work on the Skill. I look forward to contributing.

@Clifford-Foster
Copy link
Author

Also, apologies but there is a missing closing '}' in that. I did a quick clean on the code as it had lots of log statements. I'll fix when I get home tonight.

@Clifford-Foster
Copy link
Author

Clifford-Foster commented Apr 16, 2018

Updated with missing

  context.succeed(result);
}

@jsetton
Copy link

jsetton commented May 16, 2018

@Clifford-Foster I just brought up that topic in the main project. Did you enable the "Send Alexa Events" permission on your skill? That would explain why you needed the skill to respond to Alexa.Authorization directives since the skill cannot be enabled at the user level if no successful response is sent back. But, from my understanding, this scenario only happens when that permission is enabled.

image

@Clifford-Foster
Copy link
Author

@jsetton that's exactly what I did ... without thinking through the implications :) Thanks for solving the mystery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants