Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number fixing et al #457

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Version number fixing et al #457

merged 6 commits into from
Dec 10, 2024

Conversation

hernil
Copy link
Contributor

@hernil hernil commented Dec 10, 2024 •
edited by runeflobakk
Loading

Like any good PR this does three tings at once ...

  • We do some version bumping of dotnet as well as some pipeline runners
  • We disable client side certificate validation (00e4972) for tests as we have gone from Buypass-issued certs to Digipost-issued ones. See commit for more information (there is no security implication as everything is validated server-side)
  • We manually insert version information to the Directory.build.props file that hopefully gets properly embedded into the final build artifact so as to be reflected in the user-agent string of the client. This will allow us to see what version of the client is actually used out there.

Hopefully we'll get to package a few more dependency bumps and the like soon™

hernil added 6 commits November 8, 2024 14:53
@hernil
github actions: Test upgrade of setup-dotnet
a8d25d7
@hernil
Use sed for inserting version number
f82f8fc
@hernil
tests: Disable client side certificate validation
00e4972 
We have updated the client test certificates to internally issued ones
instead of Buypass certificates. This should not affect any environments
as our cert authority should be configured but the client side
validation in this code base is strict by default.

Disable the validation locally. Server side validation is still active
so using a certificate not originating from a valid authority or
Digipost will fail.
@hernil
Update from netcoreapp3.1 to net8.0
12046a6
@hernil
ci: Bump versions in actions
b5e5a31
@hernil
ci: debug
2b50ea1 
Add a sha256 output of the base64 decoded certificate for debug purposes

Do
`pass Qa/Nokler_og_sertifikater/Bring_Digital_Signature_Key_Encipherment_Data_Encipherment/key | base64 -D | sha256sum`
on the local machine to check for a match
runeflobakk
runeflobakk approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@runeflobakk runeflobakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works 🤞

@hernil hernil merged commit 719df0f into main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runeflobakk runeflobakk runeflobakk approved these changes

@eivinhb eivinhb Awaiting requested review from eivinhb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernil @runeflobakk