Support both country code 9908 and 0192 in Organisasjonsnummer #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults when using country code The previous implementation, which I somewhat regrettably released as version 4.0.2, is not ideal when comparing an organisation number without country code to an organisation number with country code. The changes made here establish that in such cases, only the organisation numbers should be compared, disregarding country codes.
…mmer The changes introduced in the two previous commits change the behaviour of the Organisasjonsnummer equals method. Previously, this method could be used to compare only the organisation number string itself between two instances of Organisasjonsnummer. The method introduced in this commit, erSammeOrganisasjonsnummerUavhengigAvLandkode, is intended to replace the described use of the equals method for uses where ignoring country code is desirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.