DataType for accessing shared document in share-documents-request #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to register when and by who a shared document has been accessed. These events must contain all necessary information regarding the shared document, because metadata about the shared document itself is not known once the sharing has stopped. This enables both sender and receiver to see a history of access even after the sharing is stopped. Additionally, the SharingStopped type is extended with optional fields explaining which party stopped the sharing. This is especially important for senders, who may be confused by the state of their sharing request in the event that the receiver stops the sharing before the sender has had the chance to access the shared documen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to register when and by who a shared document has been accessed. These events must contain all necessary information regarding the shared document, because metadata about the shared document itself is not known once the sharing has stopped. This enables both sender and receiver to see a history of access even after the sharing is stopped.
Additionally, the SharingStopped type is extended with optional fields explaining which party stopped the sharing. This is especially important for senders, who may be confused by the state of their sharing request in the event that the receiver stops the sharing before the sender has had the chance to access the shared document.