Update new field referenceNumber to be remittanceInformation, and pay…

…mentScheduledDate to be not required, and fields to not be @NotNull
digipost · Jan 3, 2024 · aebac2c · aebac2c
1 parent 36b4f02
commit aebac2c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/readme.md b/readme.md
@@ -419,17 +419,17 @@ Payment information for an invoice
 
 ### Fields
 
-| Name                 |Type| Required | Description                                                                 |
-|----------------------|----|----------|-----------------------------------------------------------------------------|
-| paymentId            |String| yes      | Unique id to reference the payment with third party                         |
-| paymentStatus        |String| yes      | A status a given payment is in. ISO20022 payment statuses can be used       |
-| paymentTime          |ZonedDateTime| yes      | When the payment is done                                                    |
-| debtorAccount        |String| yes      | The debtor account for the payment. Exactly 11 digits                       |
-| debtorAccountName    |String| no       | Optional name of the account                                                |
-| paymentChannel       |String| yes      | Name the third party performing the payment                                 |
-| paymentBank          |[Bank](#invoicepaymentbank)| yes      | The bank payment is registered with                                         |
-| paymentScheduledDate |ZonedDateTime| yes      | When the payment is scheduled to be paid                                    |
-| referenceNumber      |String| no       | Optional reference number user inputted when invoice was missing KID number |
+| Name                  |Type| Required | Description                                                                 |
+|-----------------------|----|----------|-----------------------------------------------------------------------------|
+| paymentId             |String| yes      | Unique id to reference the payment with third party                         |
+| paymentStatus         |String| yes      | A status a given payment is in. ISO20022 payment statuses can be used       |
+| paymentTime           |ZonedDateTime| yes      | When the payment is done                                                    |
+| debtorAccount         |String| yes      | The debtor account for the payment. Exactly 11 digits                       |
+| debtorAccountName     |String| no       | Optional name of the account                                                |
+| paymentChannel        |String| yes      | Name the third party performing the payment                                 |
+| paymentBank           |[Bank](#invoicepaymentbank)| yes      | The bank payment is registered with                                         |
+| paymentScheduledDate  |ZonedDateTime| no       | When the payment is scheduled to be paid                                    |
+| remittanceInformation |String| no       | Optional reference number user inputted when invoice was missing KID number |
 
 ### InvoicePayment.Bank
 

diff --git a/src/main/java/no/digipost/api/datatypes/types/invoice/InvoicePayment.java b/src/main/java/no/digipost/api/datatypes/types/invoice/InvoicePayment.java
@@ -57,12 +57,10 @@ public class InvoicePayment implements DataType {
 
     @XmlElement(required = true, name = "payment-scheduled-date")
     @Description("The date the payment is scheduled for")
-    @NotNull
     ZonedDateTime paymentScheduledDate;
 
-    @XmlElement(name = "reference-number")
-    @Description("The referenceNumber user has entered when paying the invoice for missing KID")
-    @NotNull
+    @XmlElement(name = "remittance-information")
+    @Description("The reference-number user has entered when paying the invoice for missing KID")
     String referenceNumber;
 
     public static final InvoicePayment EXAMPLE = new InvoicePayment(