gjør sender optional

readme.md

@@ -224,15 +224,15 @@ Details about a pickup notice
 |Name|Type|Required|Description|
 |----|----|--------|-----------|
 |parcelId|String|yes|The id of the parcel in posten|
-|parcelUUID|String|yes|The uuid of the parcel|
+|parcelUUID|String|no|The uuid of the parcel|
 |barcode|[Barcode](#pickupnoticebarcode)|yes|Barcode|
-|productName|String|yes|Mail Service product name|
+|productName|String|no|Mail Service product name|
 |arrivalDateTime|ZonedDateTime|yes|ISO8601 full DateTime for arrival at pickup place|
 |returnDateTime|ZonedDateTime|yes|ISO8601 full DateTime for return back to sender|
 |recipient|[Recipient](#pickupnoticerecipient)|yes|The recipient of the parcel|
-|sender|[Sender](#pickupnoticesender)|yes|The sender of the parcel|
+|sender|[Sender](#pickupnoticesender)|no|The sender of the parcel|
 |pickupPlace|[PickupPlace](#pickupnoticepickupplace)|yes|where the parcel can be fetched|
-|thePackage|[Package](#pickupnoticepackage)|yes|package information|
+|thePackage|[Package](#pickupnoticepackage)|no|package information|
 |cost|[Cost](#pickupnoticecost)|no|Information about value, mva, customs processing and more|
 
 ### PickupNotice.Barcode
@@ -265,7 +265,7 @@ Details about a pickup notice
 
 |Name|Type|Required|Description|
 |----|----|--------|-----------|
-|name|String|yes|The senders name|
+|name|String|no|The senders name|
 |reference|String|no|The senders reference|
 |address|[Address](#pickupnoticeaddress)|no||
 

src/main/java/no/digipost/api/datatypes/types/pickup/PickupNotice.java

@@ -30,15 +30,15 @@ public class PickupNotice implements DataType {
     @Valid
     String parcelId;
 
-    @XmlElement(name = "parcel-uuid", required = true)
+    @XmlElement(name = "parcel-uuid")
     @Description("The uuid of the parcel")
     String parcelUUID;
 
     @XmlElement(name = "barcode", required = true)
     @Description("Barcode")
     Barcode barcode;
 
-    @XmlElement(name = "product-name", required = true)
+    @XmlElement(name = "product-name")
     @Description("Mail Service product name")
     String productName;
 
@@ -58,9 +58,8 @@ public class PickupNotice implements DataType {
     @Valid
     Recipient recipient;
 
-    @XmlElement(name = "sender", required = true)
+    @XmlElement(name = "sender")
     @Description("The sender of the parcel")
-    @NotNull
     @Valid
     Sender sender;
 
@@ -70,7 +69,7 @@ public class PickupNotice implements DataType {
     @Valid
     PickupPlace pickupPlace;
 
-    @XmlElement(name = "package", required = true)
+    @XmlElement(name = "package")
     @Description("package information")
     Package thePackage;
 

src/main/java/no/digipost/api/datatypes/types/pickup/Sender.java

@@ -18,11 +18,11 @@
 @Wither
 public class Sender {
 
-    @XmlElement(name = "name", required = true)
+    @XmlElement(name = "name")
     @Description("The senders name")
     String name;
 
-    @XmlElement(name = "reference", required = false)
+    @XmlElement(name = "reference")
     @Description("The senders reference")
     String reference;