Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support containerStyle option as in previous release #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support containerStyle option as in previous release #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ const _debounce = require('lodash.debounce')
const React = require('react')
const onElementResize = require('element-resize-event')

const defaultContainerStyle = {
width: '100%',
height: '100%',
padding: 0,
border: 0
}

function defaultGetDimensions (element) {
return [element.clientWidth, element.clientHeight]
}
Expand Down Expand Up @@ -73,11 +80,12 @@ function defaultGetDimensions (element) {
* module.exports = Dimensions()(MyComponent) // Enhanced component
*
*/
module.exports = function Dimensions ({
export default function Dimensions ({
getDimensions = defaultGetDimensions,
debounce = 0,
debounceOpts = {},
elementResize = false
elementResize = false,
containerStyle = defaultContainerStyle
} = {}) {
return (ComposedComponent) => {
return class DimensionsHOC extends React.Component {
Expand Down Expand Up @@ -161,13 +169,9 @@ module.exports = function Dimensions ({
// only trigger a warning about the wrapper div if we already have a reference to it
console.warn('Wrapper div has no height or width, try overriding style with `containerStyle` option')
}
const wrapperStyle = {
overflow: 'visible',
height: 0,
width: 0
}

return (
<div style={wrapperStyle} ref='wrapper'>
<div style={containerStyle} ref='wrapper'>
{(containerWidth || containerHeight) &&
<ComposedComponent
{...this.state}
Expand Down