Optionally disable wrappedInstance ref #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any plans to merge this? cc @digidem |
LINKIWI
reviewed
Jan 1, 2017
| return ( | ||
| <div style={wrapperStyle} ref='wrapper'> | ||
| {(containerWidth || containerHeight) && | ||
| <ComposedComponent | ||
| {...this.state} | ||
| {...this.props} | ||
| updateDimensions={this.updateDimensions} | ||
| ref='wrappedInstance' | ||
| ref={ref} |
There was a problem hiding this comment.
This can be condensed to ref={withRef && 'wrappedInstance'}
Stateless components cannot use refs, so this adds the withRef option (enabled by default for compatibility) which enables or disables passing the wrappedInstance ref to the wrapped component. Addresses issue digidem#30. Inspired by reduxjs/react-redux@2d3d0be
Aesthetikx
force-pushed
the
optional_ref
branch
from
5a08c12 to
7479331
Compare
|
@LINKIWI 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #30, inspired by react-redux/2d3d0beade5
Defaults to true to maintain compatibility.