Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reindexing #45

Merged
merged 3 commits into from
Oct 30, 2024
Merged

feat: reindexing #45

merged 3 commits into from
Oct 30, 2024

Conversation

EvanHahn
Copy link
Contributor

Passing the reindex option in the constructor will re-initialize the index from scratch.

This is motivated by this issue in @comapeo/core.

@EvanHahn EvanHahn marked this pull request as draft October 30, 2024 15:07
Passing the `reindex` option in the constructor will re-initialize the
index from scratch.

This is motivated by [this issue in `@comapeo/core`][0].

[0]: digidem/comapeo-core#436
@EvanHahn EvanHahn marked this pull request as ready for review October 30, 2024 15:15
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggested test improvement, otherwise LGTM

const storage = ram.reusable()

const indexer1 = new MultiCoreIndexer(cores, {
batch: async () => {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to capture these entries and verify that they are being indexed the first time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 705ee8d.

@EvanHahn EvanHahn merged commit b8a7957 into main Oct 30, 2024
2 checks passed
@EvanHahn EvanHahn deleted the reindex branch October 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants