feat: adding self-hosted servers #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: [email protected] <[email protected]>
We wrote this to test something and no longer need it.
This is a minor change. I think it makes sense to use `await` in an async function, rather than using `then` to handle the promise. (I guess we're `await`ing in either case, but I think this is clearer.)
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: [email protected] <[email protected]>
|
| Status | Count |
|---|---|
| 3 | |
| 24 |
Click to toggle table visibility
| Name | Status | Previous | Current |
|---|---|---|---|
@emnapi/core |
1.2.0 | - | |
@emnapi/runtime |
1.2.0 | - | |
@emnapi/wasi-threads |
1.0.1 | - | |
@fastify/ajv-compiler |
3.5.0 | - | |
@fastify/fast-json-stringify-compiler |
4.3.0 | - | |
@napi-rs/wasm-runtime |
0.2.4 | - | |
@node-rs/crc32-android-arm-eabi |
1.10.3 | - | |
@node-rs/crc32-android-arm64 |
1.10.3 | - | |
@node-rs/crc32-darwin-arm64 |
1.10.3 | - | |
@node-rs/crc32-darwin-x64 |
1.10.3 | - | |
@node-rs/crc32-freebsd-x64 |
1.10.3 | - | |
@node-rs/crc32-linux-arm-gnueabihf |
1.10.3 | - | |
@node-rs/crc32-linux-arm64-gnu |
1.10.3 | - | |
@node-rs/crc32-linux-arm64-musl |
1.10.3 | - | |
@node-rs/crc32-wasm32-wasi |
1.10.3 | - | |
@node-rs/crc32-win32-arm64-msvc |
1.10.3 | - | |
@node-rs/crc32-win32-ia32-msvc |
1.10.3 | - | |
@node-rs/crc32-win32-x64-msvc |
1.10.3 | - | |
@tybys/wasm-util |
0.9.0 | - | |
@types/ws |
- | 8.5.12 | |
clone |
- | 1.0.4 | |
execa |
7.2.0 | - | |
get-stream |
6.0.1 | - | |
human-signals |
4.3.1 | - | |
npm-run-path |
5.1.0 | - | |
strip-final-newline |
3.0.0 | - | |
ws |
- | 8.18.0 |
This was referenced Oct 31, 2024
Merged
EvanHahn
added a commit
that referenced
this pull request
Oct 31, 2024
We couldn't add end-to-end tests for the server until `@comapeo/server` was released (see [#952] for more details). Now that it's out, we can add them! [#952]: #952 Co-Authored-By: Gregor MacLennan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for adding self-hosted servers. It adds the following functions:
project.$member.addServerPeer()project.$sync.connectServers()project.$sync.disconnectServers()This change doesn't include end-to-end tests for the server. That's deliberate! We can't (easily) add those tests without the server being released, but we can't (easily) release the server without this change. Once this change is released, we can release the server, and then we should be able to add end-to-end tests.
See #886 for more.
Because Gregor and I paired on this extensively, I plan to merge and deploy this once ready.
Co-Authored-By: Gregor MacLennan [email protected]