Bugfix/php8 issues (#337)

Fixed some php8 issues and share viewcontext of configuration with request

CHANGELOG.md

@@ -3,10 +3,12 @@
 Changelog
 ---------
 
-v1.18.0 (??.10.2023)
+v1.18.0 (??.11.2023)
 
 * Auto-detect module identifier to avoid boilerblade-code
 * BC: Parameter type of exceptions changed in ExceptionHandlerInterface to \Throwable
+* Share ViewContext instance of current configuration with current request
+* Fixed some PHP 8 issues
 
 v1.17.4 (22.09.2023)
 

Classes/Backend/Form/ToolBox.php

@@ -1161,7 +1161,7 @@ public function getStoredRequestData($key, $changed = [], $modName = 'DEFRNBASEM
         }
         $ret = BackendUtility::getModuleData([$key => ''], $changed, $modName);
 
-        return $ret[$key];
+        return $ret[$key] ?? null;
     }
 
     /**

Classes/Backend/Module/ModFuncFrame.php

@@ -78,7 +78,7 @@ public function render(IModFunc $modFunc, callable $renderFunc, ServerRequestInt
         $this->currentModule = $request->getAttribute('module');
         $this->getLanguageService()->includeLLFile('EXT:rn_base/Resources/Private/Language/locallang.xlf');
         $config = $this->getConfigurations();
-        $files = $config->get('languagefiles.');
+        $files = $config->get('languagefiles.') ?? [];
         foreach ($files as $filename) {
             $this->getLanguageService()->includeLLFile($filename);
         }

Classes/Backend/Utility/Tables.php

@@ -183,7 +183,7 @@ protected function prepareRow($entry, $columns, $formTool, $options)
      * Liefert die passenden Überschrift für die Tabelle.
      *
      * @param array $columns
-     * @param array $options
+     * @param DataModel $options
      * @param \Sys25\RnBase\Backend\Form\ToolBox $formTool
      *
      * @return array

Classes/Configuration/Processor.php

@@ -32,6 +32,7 @@
 use ArrayObject;
 use Sys25\RnBase\Exception\SkipActionException;
 use Sys25\RnBase\Frontend\Marker\FormatUtil;
+use Sys25\RnBase\Frontend\View\ViewContext;
 use Sys25\RnBase\Utility\Arrays;
 use Sys25\RnBase\Utility\Debug;
 use Sys25\RnBase\Utility\Extensions;
@@ -200,7 +201,7 @@ class Processor implements ConfigurationInterface
     public function __construct()
     {
         $this->_dataStore = new ArrayObject();
-        $this->_viewData = new ArrayObject();
+        $this->_viewData = new ViewContext();
         $this->_keepVars = new ArrayObject();
         $this->localLangUtil = tx_rnbase::makeInstance(Language::class);
     }

Classes/Domain/Repository/FeUserRepository.php

@@ -90,7 +90,7 @@ public function getInstance(int $uid)
         if (!$uid) {
             throw new Exception('No uid for fe_user given!');
         }
-        if (!is_object(self::$instances[$uid])) {
+        if (!isset(self::$instances[$uid])) {
             self::$instances[$uid] = $this->findByUidForced($uid);
         }
 

Classes/Frontend/Marker/BaseMarker.php

@@ -218,7 +218,7 @@ public static function initLink(&$markerArray, &$subpartArray, &$wrappedSubpartA
             return; // Nothing to do
         }
 
-        $linkObj = &$formatter->getConfigurations()->createLink();
+        $linkObj = $formatter->getConfigurations()->createLink();
         $token = self::getToken();
         $linkObj->label($token);
         $links = $formatter->getConfigurations()->get($confId.'links.');
@@ -357,7 +357,7 @@ protected function getDefaultMarkerArray()
      */
     protected static function getEmptyInstance($classname)
     {
-        if (!is_object(self::$emptyObjects[$classname])) {
+        if (!isset(self::$emptyObjects[$classname])) {
             /* @var $dummy DomainModelInterface */
             $dummyInstance = tx_rnbase::makeInstance($classname, ['uid' => 0]);
             if ($dummyInstance instanceof DomainModelInterface

Classes/Frontend/Request/Request.php

@@ -4,7 +4,6 @@
 
 use Sys25\RnBase\Configuration\ConfigurationInterface;
 use Sys25\RnBase\Frontend\View\ContextInterface;
-use Sys25\RnBase\Frontend\View\ViewContext;
 
 /***************************************************************
 * Copyright notice
@@ -47,7 +46,7 @@ public function __construct(
         $this->configurations = $configurations;
         $this->confId = $confId;
         $this->parameters = $parameters;
-        $this->viewContext = new ViewContext();
+        $this->viewContext = $configurations->getViewData();
     }
 
     public function getConfigurations(): ConfigurationInterface

Classes/Search/SearchBase.php

@@ -199,7 +199,7 @@ public function search(array $fields, array $options = [])
 
                         continue;
                     }
-                    list($tableAlias, $col) = explode('.', $field);
+                    list($tableAlias, $col) = array_pad(explode('.', $field), 2, null);
                     if (!isset($col)) {
                         $orderby[] = $tableAlias.' '.('DESC' == strtoupper($order) ? 'DESC' : 'ASC');
                     } else {

Classes/Utility/Files.php

@@ -57,6 +57,7 @@ public static function getFileResource($fName, $options = [])
         if (null === $incFile) {
             $incFile = self::getFileName($fName);
         }
+        $ret = '';
         if ($incFile) {
             // Im BE muss ein absoluter Pfad verwendet werden
             $fullPath = Environment::isBackend() ? Environment::getPublicPath().$incFile : $incFile;