Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tokens): Update to new color scale #3069

Merged
merged 16 commits into from
Jan 29, 2025

Conversation

mimarz
Copy link
Collaborator

@mimarz mimarz commented Jan 28, 2025

part of #3029

  • Renamed
    • color contrast-1 to 16
    • color contrast-2 to 15
  • Added
    • color surface-default, now total of 16 colors per scale instead of 15
  • Changed
    • Semantic color mapping is shifted down one color step to accomodate for new surface-default color at step 3
    • New ordering of colors in semantic layers.
      • Contrast colors swapped places
      • Based moved to after border but before contrast

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 6f52ed9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Preview deployments for this pull request:

Storybook - 29. Jan 2025 - 12:47

Storefront - 29. Jan 2025 - 12:48

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 52.4% 2980 / 5687
🔵 Statements 52.4% 2980 / 5687
🔵 Functions 82.94% 180 / 217
🔵 Branches 76.79% 523 / 681
File CoverageNo changed files found.
Generated in workflow #1871 for commit 6f52ed9 by the Vitest Coverage Report Action

@mimarz
Copy link
Collaborator Author

mimarz commented Jan 28, 2025

To review for visual tests

@Febakke also needs to test design-token changes in Figma.

@mimarz mimarz marked this pull request as ready for review January 28, 2025 20:09
@mimarz mimarz merged commit 064af6d into chore-neutral-default Jan 29, 2025
7 checks passed
@mimarz mimarz deleted the new-color-scale-design-tokens branch January 29, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants