Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make sure there is always on main color #3009

Merged
merged 3 commits into from
Jan 17, 2025
Merged

chore: make sure there is always on main color #3009

merged 3 commits into from
Jan 17, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 17, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3151875

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review January 17, 2025 09:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Preview deployments for this pull request:

Theme - 17. Jan 2025 - 13:36

mimarz
mimarz reviewed Jan 17, 2025
View reviewed changes
apps/theme/components/Sidebar/ColorPane/ColorPane.tsx Outdated
)}
<Tooltip
content='Du må ha minst en hovedfarge'
hidden={colorType !== 'main' || mainColors.length > 1}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this also use disableRemoveButton? It should only show when button is disabled no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, forgot to change it here. Nice catch

@Barsnes Barsnes merged commit c4e8596 into next Jan 17, 2025
3 checks passed
@Barsnes Barsnes deleted the theme/main-color branch January 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz