fix: focus-outer -> neutral.text.default #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e9d2d49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - Storefront - |
mimarz
changed the title
Coverage Report
File CoverageNo changed files found. |
Barsnes
reviewed
Jan 14, 2025
.changeset/fast-cows-impress.md
Outdated
Comment on lines
2
to
5
| "@digdir/designsystemet": patch | ||
| --- | ||
|
|
||
| tokens: fix wrong reference for focus color. Now uses neutral color |
There was a problem hiding this comment.
Should this changeset be for css or theme as well?
There was a problem hiding this comment.
its all built from tokens so unsure. I can try rephrasing it.
There was a problem hiding this comment.
If it's present/used in our css, I think it should be there as well
There was a problem hiding this comment.
Its part of the theme thats in the package or users generate themselves
mimarz
approved these changes
Jan 14, 2025
Barsnes
approved these changes
Jan 14, 2025
mimarz
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @digdir/[email protected] ### Minor Changes - Add JSON schema for CLI config file, which enables editor hints. To use it, do something like this: ([#2972](#2972)) ```jsonc { "$schema": "node_modules/@digdir/designsystemet/dist/config.schema.json", // ...config options here... } ``` - cli: better error messages for wrong or missing options ([#2970](#2970)) ### Patch Changes - tokens: fix wrong reference for focus color. ([#2989](#2989)) - refactor: Changed border-radius token to dimension type ([#2990](#2990)) - Add json config file support for `tokens create` ([#2847](#2847)) - Changed focus color to use neutral instead of accent color ([#2989](#2989)) - tokens build: fix invalid values in --ds-size calculations ([#2975](#2975)) - outDir option was required, but it should have a default value ([#2969](#2969)) ## @digdir/[email protected] ### Patch Changes - Helptext: Remove component ([#2956](#2956)) - Field: Don't show as disabled when option is disabled ([#2980](#2980)) - Changed focus color to use neutral instead of accent color ([#2989](#2989)) - Tabs: Rework component CSS ([#2991](#2991)) ## @digdir/[email protected] ### Patch Changes - Input: Add whitelist for `type` ([#2974](#2974)) - Helptext: Remove component ([#2956](#2956)) - Textfield: Add whitelist for `type` ([#2974](#2974)) - Tabs: Content will get focus when it has no focusable elements ([#2991](#2991)) ## @digdir/[email protected] ### Patch Changes - Changed focus color to use neutral instead of accent color ([#2989](#2989)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2985
focus-outerreferenced the accent scale, this scale is not static and can change. Neutral is a safer scale to use as a reference here.