Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update storybook, test with theme decorator again #2957

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 7, 2025

The issues we have with hooks not working in stories is now working.

However, it seems like how the theme decorator works has changed a bit:

  • We need to select elements that disappear, since it does not re-evaluate on page change
  • Only the first story on a doc page gets the data attr

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 204cad5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Preview deployments for this pull request:

Storybook - 7. Jan 2025 - 16:43

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.14% 3198 / 5799
🔵 Statements 55.14% 3198 / 5799
🔵 Functions 85.84% 182 / 212
🔵 Branches 77.31% 525 / 679
File CoverageNo changed files found.
Generated in workflow #1496 for commit 204cad5 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant