You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
We have an issue with all tabpanels being visible in snapshots and on our storybook if you refresh or navigate to directly. Any ideas how to fix this? @eirikbacker
- Respect `hidden` attribute on all components
- Updated #2450
- Did not fix tabs as this is fixed in
#2944
---------
Co-authored-by: Barsnes <[email protected]>
Since we have just one use-case of Tabs with u-tabs being rendered wrong I suggest we create a new branch and make a EXPERIMENTAL_Tabs component alongside the existing Tabs component so that we can better test the u-tabs implementation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2449
The controlled version of this had to be reworked, as
valueis no longer used.