-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: article about data-size
#2940
Conversation
|
Preview deployments for this pull request: Storefront - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I feel we are missing some important information to explain how sizing and data-size
works.
I think we should explain in the ingress that component size is based of, font-size and an em calculation. Our data-size
is just a recommended sizing scale.
One of the strengths of going over to this new method is so that people can freely make their own sizing formulas and define it globally.
This is not inline with how the article on colors is : https://www.designsystemet.no/grunnleggende/for-utviklere/fargar I'd like to keep them in the same writing form, and on that article, we decided that what happens is not important here, since this article is for everyone |
And to add to this, we have this in the igress:
What would you change here? |
apps/storefront/app/grunnleggende/for-utviklere/storrelsar/page.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
resolves #2928