Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: article about data-size #2940

Merged
merged 8 commits into from
Jan 10, 2025
Merged

docs: article about data-size #2940

merged 8 commits into from
Jan 10, 2025

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Jan 2, 2025

resolves #2928

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: e418029

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Preview deployments for this pull request:

Storefront - 10. Jan 2025 - 08:22

@Barsnes Barsnes marked this pull request as ready for review January 2, 2025 14:07
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I feel we are missing some important information to explain how sizing and data-size works.

I think we should explain in the ingress that component size is based of, font-size and an em calculation. Our data-size is just a recommended sizing scale.

One of the strengths of going over to this new method is so that people can freely make their own sizing formulas and define it globally.

@Barsnes
Copy link
Member Author

Barsnes commented Jan 9, 2025

Looks good! I feel we are missing some important information to explain how sizing and data-size works.

I think we should explain in the ingress that component size is based of, font-size and an em calculation. Our data-size is just a recommended sizing scale.

One of the strengths of going over to this new method is so that people can freely make their own sizing formulas and define it globally.

This is not inline with how the article on colors is : https://www.designsystemet.no/grunnleggende/for-utviklere/fargar

I'd like to keep them in the same writing form, and on that article, we decided that what happens is not important here, since this article is for everyone

@Barsnes
Copy link
Member Author

Barsnes commented Jan 9, 2025

Looks good! I feel we are missing some important information to explain how sizing and data-size works.
I think we should explain in the ingress that component size is based of, font-size and an em calculation. Our data-size is just a recommended sizing scale.
One of the strengths of going over to this new method is so that people can freely make their own sizing formulas and define it globally.

This is not inline with how the article on colors is : https://www.designsystemet.no/grunnleggende/for-utviklere/fargar

I'd like to keep them in the same writing form, and on that article, we decided that what happens is not important here, since this article is for everyone

And to add to this, we have this in the igress:

Våre size-variablar (--ds-size-*) endrar seg basert på den lokale skriftstørrelsen. Du kan lett endre den ved bruk av data-size.

What would you change here?

@Barsnes Barsnes requested a review from mimarz January 10, 2025 07:19
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Barsnes Barsnes merged commit 17bfe62 into next Jan 10, 2025
4 checks passed
@Barsnes Barsnes deleted the docs/data-size branch January 10, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how data-size works: globally and on components
2 participants