Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain the difference between spacing and sizing in figma #1865

Merged
merged 4 commits into from
Apr 25, 2024
Merged

docs: explain the difference between spacing and sizing in figma #1865

merged 4 commits into from
Apr 25, 2024

Conversation

mrosvik
Copy link
Member

@mrosvik mrosvik commented Apr 23, 2024

Resolves #1864

@mrosvik mrosvik marked this pull request as ready for review April 23, 2024 07:29
@mrosvik mrosvik requested review from mimarz and Barsnes as code owners April 23, 2024 07:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Preview deployments for this pull request:

🖥 Storefront 24. Apr 2024 - 14:15 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@mrosvik
Copy link
Member Author

mrosvik commented Apr 24, 2024

Need approving review from @mimarz or @Barsnes 😊

@mimarz mimarz merged commit 6c7073c into main Apr 25, 2024
4 checks passed
@mimarz mimarz deleted the docs/why-both-spacing-and-sizing branch April 25, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why do we have both sizing and spacing?
3 participants
@mrosvik @mimarz @Barsnes