Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(Textarea): add missing error border #1853

Merged
merged 4 commits into from
Apr 19, 2024
Merged

style(Textarea): add missing error border #1853

merged 4 commits into from
Apr 19, 2024

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Apr 19, 2024

Resolves #1847

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited
Loading

Preview deployments for this pull request:

📖 Storybook 19. Apr 2024 - 08:57 (Norwegian time)

See all deployments at https://dev.designsystemet.no

@Barsnes Barsnes changed the title style(Textarea): Add missing error border style(Textarea): add missing error border Apr 19, 2024
@Barsnes Barsnes marked this pull request as ready for review April 19, 2024 06:41
@Barsnes Barsnes requested a review from mimarz as a code owner April 19, 2024 06:41
mimarz
mimarz requested changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also fix this by adding the hasError && classes.error on "formfield" div.

packages/react/src/components/form/Textarea/Textarea.module.css Outdated Show resolved Hide resolved
@Barsnes Barsnes requested a review from mimarz April 19, 2024 07:00
mimarz
mimarz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Barsnes Barsnes merged commit fc6c0c5 into main Apr 19, 2024
4 checks passed
@Barsnes Barsnes deleted the fix/textarea-border branch April 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display red border on Textarea when error is set
2 participants
@Barsnes @mimarz