Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdfmorph web-page #23
base: source
Are you sure you want to change the base?
Pdfmorph web-page #23
Changes from all commits
3cd884f
59c2995
726a7b1
27a78fc
b05ea1a
afcd519
92d28ed
87f5b62
46364ae
9b51ea7
9408726
2300e7c
d87c500
1ee2756
13435df
aaa81dd
4bc49b4
612a7b9
76f0294
54417fd
ea9dcec
13c79ea
02628b0
e5bccef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to connect directly to the license file in the package top level directory? This would be more robust/maintainable than having two license files hanging around. What if they are different? Which one is the correct one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For diffpy-cmi packages I use a dedicated
license
branch athttps://github.com/diffpy/diffpy-release/tree/license.
I make any text updates in the "license" branch and merge it to each package just before release, e.g., here.
Perhaps we could add a new
license-pdfmorph
branch to the "diffpy-release" repo and keep on merging it to this webpage sources and to the "diffpy.pdfmorph" master as well. If license files come from a common upstream branch, they will stay in sync.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this something that would be top-priority upon release?