Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jakarta Validation's Valid and constraints annotations #2335

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Add Jakarta Validation's Valid and constraints annotations #2335

merged 4 commits into from
Nov 14, 2024

Conversation

jskov
Copy link
Contributor

@jskov jskov commented Nov 10, 2024

This causes formatAnnotations to place the annotation on the same line as the type.
This fixes #2334

@jskov jskov marked this pull request as draft November 10, 2024 12:58
@jskov
Copy link
Contributor Author

jskov commented Nov 10, 2024

This should probably include all the (relevant) Validation annotation types.
Will add if it makes sense, see #2334

@nedtwigg nedtwigg marked this pull request as ready for review November 13, 2024 17:03
@nedtwigg nedtwigg marked this pull request as draft November 13, 2024 17:03
@jskov jskov changed the title Add (jakarta validation) Valid as a type annotation Add Jakarta Validation's Valid and constraint annotations Nov 14, 2024
@jskov jskov changed the title Add Jakarta Validation's Valid and constraint annotations Add Jakarta Validation's Valid and constraints annotations Nov 14, 2024
@jskov jskov marked this pull request as ready for review November 14, 2024 17:56
@jskov jskov mentioned this pull request Nov 14, 2024
Closed
@nedtwigg
Copy link
Member

Thanks!

@nedtwigg nedtwigg merged commit 575d683 into diffplug:main Nov 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jakarta Validation @Valid annotation is not treated as a type-annotation
2 participants
@jskov @nedtwigg