-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQLite function json_pretty
#4395
Merged
weiznich
merged 5 commits into
diesel-rs:master
from
xuehaonan27:add_sqlite_json_pretty
Dec 19, 2024
+349
−3
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
87f932a
Add SQLite function `json_pretty`
xuehaonan27 1a47889
fix: skip `json_pretty` test if not SQLite doesn't support.
xuehaonan27 9f9580f
fix: version querying
xuehaonan27 0e38689
fix: add `sql`
xuehaonan27 31d2f1c
fix: definition of `json_pretty`.
xuehaonan27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this signature is unfortunately not correct yet. The sqlite documentation says:
which would translate to
this then would require users to call it that way:
select(json_pretty(json("your_json_text"))
orselect(json_pretty(jsonb(b"your_json_blob"))
As for the optional second argument: We normally deal with that by having a second function definition for this for that.
So something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful for me since I'm new to
diesel
! Well, are you sure we should useJsonOrJsonbOrNullableJson
? I foundJsonOrNullableJsonOrJsonbOrNullableJsonb
in the PostgreSQL implementation, which adds nullableJSONB
implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct we want to use
JsonOrNullableJsonOrJsonbOrNullableJsonb
there (any likely also for most of the other sqlite json functions).