Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out M1 Runners #3923

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Try out M1 Runners #3923

merged 5 commits into from
Feb 4, 2024

Conversation

weiznich
Copy link
Member

@weiznich weiznich commented Feb 2, 2024

This PR enables the experimental m1 runners (via macos-14). This hopefully enables us to run tests on aarch64-macos as well.

Github announcement: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

In addition this PR contains various maintenance items for the workflow scrips like updating actions and replacing deprecated actions. Also it contain a bunch of fixes for non-deterministic tests to prevent the CI failing randomly.

* Bump version of actions/checkout to 0.4
* Replace actions/cache with the rust-lang specific version
* Replace the deprecated actions-rs/audit step with a maintained version
This commit fixes a lot of randomly failing tests by adding `ORDER BY`
clauses to some queries. It also prevents concurrently creating an
`INDEX` for the same table (which results in a deadlock in postgres
sometimes).

(This was tested by running `diesel_tests` in a loop until 100
continuous runs passed)
@weiznich weiznich requested a review from a team February 2, 2024 12:57
@weiznich weiznich added this pull request to the merge queue Feb 4, 2024
Merged via the queue into diesel-rs:master with commit ca8adee Feb 4, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants