Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process.kill Function #696

Merged
merged 12 commits into from
Nov 11, 2023
Merged

Process.kill Function #696

merged 12 commits into from
Nov 11, 2023

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Nov 7, 2023 •
edited
Loading

initial impl of Process.kill

Resolves: #694

What's Changed:

Adds a kill function to the Process module as well as docs.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@briandowns
initial impl of Process.kill
e0d2e82 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
fix macro
55b5a7f 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
fix macro
7c90c64 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
fix macro
acb1795 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
fix macro
8f6b4a1 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
add pid_t macro
2ae3422 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
explicit sigkill value
798c371 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
windows madness
49fe0c2 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
seperate impl for windows, update docs
3354065 
Signed-off-by: Brian Downs <[email protected]>
@briandowns
more preprocessor segmentation
1124f18 
Signed-off-by: Brian Downs <[email protected]>
@Jason2605
Copy link
Member

Just checking is this still in draft?

@briandowns briandowns marked this pull request as ready for review November 8, 2023 20:56
@briandowns briandowns self-assigned this Nov 8, 2023
@briandowns briandowns requested a review from Jason2605 November 8, 2023 20:57
@briandowns
Copy link
Contributor Author

Just checking is this still in draft?

Ready for review. Not quite sure how to test it though, effectively. I've tested it on Mac, FreeBSD, and Linux manually.

Jason2605
Jason2605 reviewed Nov 8, 2023
View reviewed changes
docs/docs/standard-lib/process.md Outdated Show resolved Hide resolved
src/optionals/process.c Outdated Show resolved Hide resolved
@briandowns
Copy link
Contributor Author

I "think" we're all set.

Jason2605
Jason2605 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@Jason2605 Jason2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@Jason2605 Jason2605 merged commit 873fa99 into dictu-lang:develop Nov 11, 2023
8 checks passed
@Jason2605 Jason2605 mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason2605 Jason2605 Jason2605 approved these changes

Assignees

@briandowns briandowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add kill function to the Process Module
2 participants
@briandowns @Jason2605