-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net module, tests, and docs #686
Conversation
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Yeah moving Socket into a more generic Net module probably makes more sense. Either that or you make separate ones for each (like Python does: https://docs.python.org/3/library/ipaddress.html / https://docs.python.org/3/library/socket.html) |
I'll defer to your judgement on how you want to move forward. Adding Socket to Net had me start thinking about sub modules within a module and how that'd work from an implementation perspective and how it'd look from a language perspective. For the latter, I like any of the following but possibly the "/" most. import Net:Socket import Net/Socket |
Yeah submodules will be an interesting one, we can kind of do it at the moment with The only other alternative we could potentially have is:
Def worth a think on the best syntax for them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of little ones
Signed-off-by: Brian Downs <[email protected]>
Thanks for this! I was thinking as well, I probably should have done it a while ago but I can send you an invite to the org if you'd like? You've done more than enough on the repo now to warrant it! Thank you very much! |
Whatever works for you, works for me. :) Thanks! |
Add net module, tests, and docs
What's Changed:
Adds a new module called "Net" with a couple constants, and functions.
I was imagining the next iteration of this to be to move the Socket module into this module, in some capacity.
Type of Change:
Housekeeping:
Screenshots (If Applicable):