Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move copyFile to IO module #683

Merged
merged 10 commits into from
Nov 1, 2023

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Oct 20, 2023

move copyFile to IO module

Resolves: #

What's Changed:

The copyFile function is moved from the System module to the IO module. The implementation for Linux and BSD based OSs has changed to be a 0 copy/in kernel copy. Windows implementation remains the same.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
@briandowns briandowns changed the title move copyFile to IO module [WIP] - Move copyFile to IO module Oct 21, 2023
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
@briandowns briandowns marked this pull request as ready for review October 25, 2023 03:57
@briandowns briandowns changed the title [WIP] - Move copyFile to IO module Move copyFile to IO module Oct 25, 2023
@briandowns
Copy link
Contributor Author

Merge conflict resolved.

@Jason2605 Jason2605 merged commit 85f061f into dictu-lang:develop Nov 1, 2023
2 checks passed
@Jason2605 Jason2605 mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants