Added functionality for isPath

[Kishore-abhimanyu]

 I worked on the ispath to check whether the given string is symbolic link or not. Added docs and test file

Context of the change :

#450 (comment)

• Bug fix

• New feature

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

[WillDaSilva]

Why is the function called isPath if it's checking whether something is a symbolic link or not? Not all paths are symbolic links.

[Kishore-abhimanyu]

Why is the function called isPath if it's checking whether something is a symbolic link or not? Not all paths are symbolic links.

File name has been changed. Could you check now?

[Jason2605]

The name the issue stated is fine, isLink.

Few things as well, you will need to add the test file to here.

The code seems to be slightly mis-indented unfortunately.

And finally, this will break windows builds. If we intend this to not work on windows (which may be a viable option to begin with) we either need to 1) remove this and make sure it doesn't get compiled on windows systems entirely. 2) Do something similar to Python where it just returns False on runtimes that don't support it (less hot on this as to me it feel like a silent fail).

[Jason2605]

Hi @Kishore-abhimanyu, it seems the tests are failing on this pull request. Are you still interested in getting this feature in?

[Kishore-abhimanyu]

Could you review now?

[Jason2605]

These tests will still end up failing unfortunately - you're asserting that "linktofile" is a symlink, however, it doesn't exist.

This will still also fail to compile on windows systems:

dictu_api_static.lib(path.obj) : error LNK2019: unresolved external symbol lstat referenced in function isLinkNative [D:\a\Dictu\Dictu\build\src\cli\dictu.vcxproj]
dictu_api_static.lib(path.obj) : error LNK2019: unresolved external symbol S_ISLNK referenced in function isLinkNative [D:\a\Dictu\Dictu\build\src\cli\dictu.vcxproj]

[Jason2605]

Closing due to inactivity