Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored to set request data in global state via middleware #33

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Refactored to set request data in global state via middleware #33

merged 2 commits into from
Sep 30, 2023

Conversation

dickdavis
Copy link
Owner

@dickdavis dickdavis commented Sep 30, 2023 •
edited
Loading

Description

This PR refactors so that request data is pulled from the request via middleware and stored in global state.

Testing

Follow these steps to test this PR:

  • Point a consuming app to this branch.
  • Log an event in the model.
  • Verify all of the request fields are logged.
  • Verify the sensitive fields are filtered.
  • Log an event in the controller.
  • Verify all of the request fields are logged.
  • Verify the sensitive fields are filtered.

@dickdavis dickdavis marked this pull request as ready for review September 30, 2023 06:53
@dickdavis dickdavis merged commit 3083db4 into main Sep 30, 2023
4 checks passed
@dickdavis dickdavis deleted the current-request branch September 30, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dickdavis