Target P #25
Merged
Target P #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arka Prava Basu <[email protected]>
- keep TAG as channelId - AudioStreamingServiceChannel as the channel name - empty notification channelId for devices below O Signed-off-by: Arka Prava Basu <[email protected]>
|
Should solve #20 |
|
Hi Arka,
Thanks for this contribution. Can I merge this changes to my ripo? have
you tested in real device ?
…On Tue 25 Dec, 2018, 1:45 PM Arka Prava Basu ***@***.*** wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#25
Commit Summary
- Updating dependencies; using androidx
- Provide a notification channel for Devices running Android O
File Changes
- *M* dmaudiostreamer/build.gradle
<https://github.com/dibakarece/DMAudioStreamer/pull/25/files#diff-0>
(13)
- *M*
dmaudiostreamer/src/main/java/dm/audiostreamer/AudioStreamingService.java
<https://github.com/dibakarece/DMAudioStreamer/pull/25/files#diff-1>
(44)
- *M* dmaudiostreamer/src/main/java/dm/audiostreamer/Logger.java
<https://github.com/dibakarece/DMAudioStreamer/pull/25/files#diff-2>
(1)
Patch Links:
- https://github.com/dibakarece/DMAudioStreamer/pull/25.patch
- https://github.com/dibakarece/DMAudioStreamer/pull/25.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#25>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AJ-A07tyWvVfYZj4066PFPhuzMxaTPk2ks5u8d6HgaJpZM4Zg6f1>
.
|
Signed-off-by: Arka Prava Basu <[email protected]>
|
Yes, tested on one device running Android Oreo and one running Android Nougat. |
|
Thanks arka will merge this changes to this repo. Can you please create one
pull request
…On Tue 25 Dec, 2018, 6:00 PM Arka Prava Basu ***@***.*** wrote:
Yes, tested on one device running Android Oreo and one running Android
Nougat.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ-A08Or1LKtEZLrSN3zASynX1yvDd1sks5u8hqBgaJpZM4Zg6f1>
.
|
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.