Task-Upgrade composition api #9

Ovsdrak · 2023-03-08T19:12:40Z

Fixes: #number

Description

Refactors all the components from Options API to Composition API

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
- Good variable naming.
- Constants are capitalized and snake cased.
- Code uses const instead of let and var.
My commit history is nice and readable
My PR doesn't contain more than 10 or max 15 files changed
I've added the number of the issue I'm fixing at the top of my file
My code has been reviewed
My code passed all the checks on the Pipeline (Action)
My change requires a change to the documentation.
I have updated the documentation accordingly.

- A composable for validation was created to replace the existing validateForm mixin.

- A composable for uploading an image was created to replace the existing uploadImage mixin.

…ructure - A composable for nullify jsons was created to replace the existing json mixin.

…tructure

…cture

… structure

…ucture

…cture

- Adds mitt emitter to global providers

…on API.

- useSelfPermissions - useAllPermissions

diavrank · 2023-03-11T02:00:12Z

imports/api/Users/UsersCtrl.ts

@@ -157,12 +157,14 @@ export const updatePersonalDataMethod = new ValidatedMethod({
 	validate({ user }: { user: Meteor.User }) {
 		try {
 			check(user, {
+				_id: String,


this is not necessary since we can take the user id from the current connection

diavrank · 2023-03-11T02:01:38Z

imports/api/Users/UsersCtrl.ts

 				username: String,
 				emails: [{ address: String, verified: Boolean }],
 				profile: {
 					profile: String,
 					name: String,
-					path: Match.Maybe(String)
+					path: Match.Maybe(String),
+					updated_at: String


can we use camel case, please?

diavrank · 2023-03-11T02:09:29Z

imports/ui/App.vue

+    onMounted(() => {
+      provide(Injections.AlertMessage, alertMessage.value);
+      provide(Injections.Loader, loader.value);
+      const emitter = mitt();
+      provide(Injections.Emitter, emitter);
+    })


what is this for?

if it is to use those components in the global scope, I had implemented in their mounted hooks the code to make them globals. Besides, I added mitt in the imports/startup/client/index.ts file to configure the event emitter as global.

diavrank · 2023-03-11T02:13:48Z

imports/ui/components/ConfigureAccount/GeneralData.vue

+    const alert = inject<AlertMessageType>(Injections.AlertMessage);
+    const loader = inject<LoaderType>(Injections.Loader);


check if we can access with global props as shown:

this.$alert this.$loader

diavrank · 2023-03-11T02:14:53Z

imports/ui/components/ConfigureAccount/GeneralData.vue

+    const dataFormObserver = ref<FormContext | null>(null);
+    const alert = inject<AlertMessageType>(Injections.AlertMessage);
+    const loader = inject<LoaderType>(Injections.Loader);
+    const emitter = inject<Emitter<Record<EventType, unknown>>>(Injections.Emitter);


check if we can use this.emitter instead

diavrank · 2023-03-11T02:26:54Z

imports/ui/components/Utilities/Loaders/Loader.vue

+export interface LoaderType {
+  activate(progressLabel: string): void;
+  deactivate(): void;
+}
+


diavrank · 2023-03-11T02:31:15Z

imports/ui/layouts/shared/FooterView.vue

@@ -2,7 +2,7 @@
  <v-footer padless>
    <div class="d-flex flex-column align-center justify-center">
      <p class="text-white text-caption">
-        ©{{ currentLocalDate().getFullYear() }} By Diavrank.
+        ©{{ currentLocalDate().getFullYear() }} By Ovsdrak.


Suggested change

©{{ currentLocalDate().getFullYear() }} By Ovsdrak.

©{{ currentLocalDate().getFullYear() }} By Antware.

diavrank · 2023-03-11T02:37:11Z

imports/ui/views/Auth/Login.vue

+    const alert = inject<AlertMessageType>(Injections.AlertMessage);
+    const loader = inject<LoaderType>(Injections.Loader);


see if we can use global variables

diavrank · 2023-03-11T02:40:33Z

imports/ui/views/Auth/ResetPassword.vue

+    <Form as="v-form" v-slot="{handleSubmit}" ref="setPasswordFormObserver">
+      <v-form @submit="handleSubmit($event, resetPassword)" autocomplete="off">


why was this changed? regarding to the v-form component. It's supposed to have v-form as an alias in the Form component, that is treated as v-form component.

diavrank · 2023-03-11T02:42:04Z

imports/ui/views/Auth/ResetPassword.vue

-          <v-text-field v-model="user.password" id="inputNewPassword"
+    <Form as="v-form" v-slot="{handleSubmit}" ref="setPasswordFormObserver">
+      <v-form @submit="handleSubmit($event, resetPassword)" autocomplete="off">
+        <Field v-slot="{field, errors}" name="password" rules="strength_password|required">


verify the functionality for this since I remembered I had problems with the initial values for this form when I added the field slot.

Ovsdrak added 3 commits March 8, 2023 13:05

Feature: Creates interfaces for callable methods of global components

3763750

Feature: Provides AlertMessage and Loader to the Global API

3e3bba6

Refactor: Updates Login component with Composition API structure

e9c606d

- A composable for validation was created to replace the existing validateForm mixin.

Ovsdrak added the WIP Work in progress label Mar 8, 2023

Ovsdrak requested a review from diavrank March 8, 2023 19:12

Ovsdrak self-assigned this Mar 8, 2023

Ovsdrak changed the base branch from dev to t_upgrade_pinia March 8, 2023 19:12

Base automatically changed from t_upgrade_pinia to upgrade-vue3 March 8, 2023 19:22

Ovsdrak added 13 commits March 8, 2023 16:10

Refactor: Updates GeneralData component with Composition API structure

c7e6aef

- A composable for uploading an image was created to replace the existing uploadImage mixin.

Refactor: Updates UpdatePassword.ts component with Composition API st…

9728f33

…ructure - A composable for nullify jsons was created to replace the existing json mixin.

Refactor: Updates ForgotPassword.vue component with Composition API s…

034ae3e

…tructure

Refactor: Updates ModalRemove.vue component with Composition API stru…

ef8ebc8

…cture

Refactor: Updates NavigationDrawer.vue component with Composition API…

cbffbbf

… structure

Refactor: Updates ListUsers.vue component with Composition API structure

5e5410c

Refactor: Updates ListProfiles.vue component with Composition API str…

d6cfe70

…ucture

Refactor: Updates SaveUser.vue component with Composition API structure

84abc7a

Refactor: Updates SaveProfile.vue component with Composition API stru…

b0075dd

…cture

Docs: Updates copyright

5e34288

Refactor: Updates UserLogged.vue component with the composition API.

f74ea2b

- Adds mitt emitter to global providers

Refactor: Updates ResetPassword.vue component with the composition API.

5f10cc8

Refactor: Updates SetInitialPassword.vue component with the compositi…

e85c55e

…on API.

Ovsdrak added RFR Ready for Review and removed WIP Work in progress labels Mar 9, 2023

Ovsdrak added 2 commits March 9, 2023 17:36

Fix: Fixes bugs related to type safety

6b3d65c

Refactor: Organizes SaveProfile.vue by features

89409ef

- useSelfPermissions - useAllPermissions

diavrank requested changes Mar 11, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Task-Upgrade composition api #9

Task-Upgrade composition api #9

Ovsdrak commented Mar 8, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

diavrank Mar 11, 2023

		const alert = inject<AlertMessageType>(Injections.AlertMessage);
		const loader = inject<LoaderType>(Injections.Loader);

	©{{ currentLocalDate().getFullYear() }} By Ovsdrak.
	©{{ currentLocalDate().getFullYear() }} By Antware.

		<Form as="v-form" v-slot="{handleSubmit}" ref="setPasswordFormObserver">
		<v-form @submit="handleSubmit($event, resetPassword)" autocomplete="off">

Task-Upgrade composition api #9

Are you sure you want to change the base?

Task-Upgrade composition api #9

Conversation

Ovsdrak commented Mar 8, 2023

Description

Screenshots (if appropriate):

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment