-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GHC 9.10 #9
Conversation
xsebek
commented
Sep 1, 2024
- add GHC 9.10 to tested
- regenerate CI
- allow base 4.20
* add GHC 9.10 to tested * regenerate CI * allow base 4.20
Hi @byorgey, I tried GHC 9.10 with Swarm and noticed this package's base version range needs to be relaxed. I am surprised this tests GHC 8.0.2 from 2017; dropping it would probably not impact anyone. |
* add GHC 9.10 to tested * regenerate CI * allow `base` 4.20 --- - blocked by `palette` package - diagrams/palette/pull/9
@@ -28,7 +28,7 @@ Library | |||
Data.Colour.Palette.Types | |||
Data.Colour.Palette.RandomColor | |||
|
|||
Build-depends: base >= 4.2 && < 4.20, | |||
Build-depends: base >= 4.2 && < 4.21, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to allow <5
since it is very stable. 🤔
I agree; I tend to just add new versions over time and never get rid of old ones until they become a problem. |
@@ -28,7 +28,7 @@ Library | |||
Data.Colour.Palette.Types | |||
Data.Colour.Palette.RandomColor | |||
|
|||
Build-depends: base >= 4.2 && < 4.20, | |||
Build-depends: base >= 4.2 && < 4.21, | |||
array >= 0.4 && < 0.6, | |||
colour >= 2.3 && < 3.0, | |||
containers >= 0.5 && < 0.7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the containers
bound need to be bumped? I don't quite understand the build failure with ghc 9.10; in fact the following local build worked for me:
cabal build --with-ghc ghc-9.10.1
containers >= 0.5 && < 0.7, | |
containers >= 0.5 && < 0.8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The currently released version of palette
on Hackage in fact has containers < 0.8
.
Closed by 933ff1d . |