Remove Template Haskell #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new code comes from expanding the old splices and performing some basic cleanup. This has various advantages, from improving compilation times to making cross-compilation vastly simpler.
|
Thanks! This looks good to me. As for the unreleased 0.3, that definitely sounds reasonable; I filed #46 to track that. There hasn't been any work on it in a long time but that may actually change soon. |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is for the release version, 0.2, as uploaded on Hackage and used by
diagrams.The unreleased 0.3 actually makes my main goal, cross-compilation (including to WASM), harder by using a custom setup. Though since that custom setup is only to enable doctests, it should be possible to remove this in favour of more modern approaches. See for example cdepillabout/pretty-simple#129.