refactor: change in order of middleware parameters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erializerFunction (#32) - mediaType, charset and boundary are removed - contentType is added
…lizerFunction (#34) - mediaType, charset and boundary are removed - contentType is added
- Remove `dataTransformer`, `dataSerializers`, and `bodyParsers` from route builder
Instead of only passing mediaType Now params can be be given as well
…#37) removes `res.next()` and `res.end()` from dredge-route
- context is now the first parameter - d is the second parameter
🦋 Changeset detectedLatest commit: 390c52e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dhrjarun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(dredge-adapters)!: change in options of BodyParser and DataSerializerFunction (#32)
refactor(dredge-fetch): change in options of BodyParser and DataSerializerFunction (#34)
refactor(dredge-types, dredge-route): remove unwanted code (#33)
dataTransformer,dataSerializers, andbodyParsersfrom route builderfeat: pass content-type to dataType value (#35)
Instead of only passing mediaType
Now params can be be given as well
test: move route type test from dredge-route to dredge-types packages (#36)
refactor(dredge-route, dredge-types)!: add
res.up()to dredge-route (#37)removes
res.next()andres.end()from dredge-routerefactor(dredge-route, dredge-types)!: replace req, res with d and context (#38)
refactor: change in order of middleware parameters