Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use dynamic org unit level analytics table columns [DHIS2-18417] #19439

Merged
merged 132 commits into from
Dec 11, 2024
Merged

fix: Use dynamic org unit level analytics table columns [DHIS2-18417] #19439

merged 132 commits into from
Dec 11, 2024

Conversation

larshelge
Copy link
Member

@larshelge larshelge commented Dec 11, 2024 •
edited by janhenrikoverland
Loading

  • In tracked entity related analytics tables, four org unit levels were hard-coded. This constraint does not exist in DHIS 2. The org unit levels should be dynamic.
  • The castBasedOnType method was effectively a duplicate of AbstractEventJdbcTableManager > getColumnExpression. Replaced the former.

@larshelge
fix: Update code
5fdf098
@larshelge
fix: Update code
12f1f27
@larshelge
fix: Update code
6647eac
@larshelge
fix: Update code
50825c4
@larshelge
fix: Update code
719655c
@larshelge
fix: Update code
c5863b1
@larshelge
fix: Update code
d2095b9
@larshelge
fix: Update code
18b9782
@larshelge
fix: Update code
d1520e3
@larshelge
fix: Update code
6c0b5a6
@larshelge
fix: Update code
7d42bb0
@larshelge
Merge branch 'master' into DHIS2-18417
1ebed16
@larshelge
fix: Update code
cb3d523
@larshelge
fix: Update code
9f369e4
@larshelge
fix: Update code
acccd5d
@larshelge
fix: Update code
97b6697
@larshelge
fix: Update code
7c725c7
@larshelge
Merge branch 'master' into DHIS2-18417
e58f104
@larshelge
Merge branch 'master' into DHIS2-18417
e8e862a
@larshelge
fix: Update code
490ea09
@larshelge
fix: Update code
781d2e4
@larshelge
fix: Update code
c1b20d7
@larshelge
fix: Update code
c51fb14
@larshelge
fix: Update code
a84ff58
@larshelge
fix: Update code
e375211
@larshelge
Merge branch 'master' into DHIS2-18417
ccbc1e4
@larshelge
fix: Update code
43ff102
@larshelge
fix: Update code
2cab8fc
@larshelge
fix: Update code
adc1599
@larshelge
Merge branch 'master' into DHIS2-18417
d013060
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
7.7% Duplication on New Code

See analysis details on SonarQube Cloud

@larshelge larshelge merged commit f4f2aca into master Dec 11, 2024
15 of 16 checks passed
@larshelge larshelge deleted the DHIS2-18417 branch December 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luciano-fiandesio luciano-fiandesio luciano-fiandesio approved these changes

@maikelarabori maikelarabori Awaiting requested review from maikelarabori

@gnespolino gnespolino Awaiting requested review from gnespolino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larshelge @luciano-fiandesio