Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement special logout url for linked accounts feature #19435

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Dec 11, 2024

Summary

Implements a new special linked account logout URL as a system configuration variable.
When all the config is set and logout is called, the user gets forwarded to this URL, but only if the logout is not called with the special 'switch' parameter used for switching users with linked accounts.

Manual test

  1. Enable 'oidc.oauth2.login.enabled' and 'linked_accounts.enabled'
  2. Set the wanted logout URL as 'linked_accounts.logout_url' in dhis.conf
  3. Start the server
  4. Log in
  5. Log out
  6. Observe you get redirected to the URL set in 'linked_accounts.logout_url'

Copy link

sonarcloud bot commented Dec 11, 2024

@netroms netroms marked this pull request as ready for review December 11, 2024 11:21
@netroms netroms merged commit 2c6105d into master Dec 11, 2024
16 checks passed
@netroms netroms deleted the DHIS2-17596 branch December 11, 2024 13:31
netroms added a commit that referenced this pull request Dec 12, 2024
* feat: implement special logout url for linked accounts feature

Signed-off-by: Morten Svanaes <[email protected]>
(cherry picked from commit 2c6105d)
netroms added a commit that referenced this pull request Dec 12, 2024
* feat: implement special logout url for linked accounts feature

Signed-off-by: Morten Svanaes <[email protected]>

(cherry picked from commit 2c6105d)
Signed-off-by: Morten Svanaes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants