test: improve test for exporting tracker event notes DHIS2-18319 #18954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the fix for the issue came in #18943 I tested it in part by asserting the /events/{uid} body is equal to /events?events={uid}. The test could hide a regression if we were to not return notes at all in both bodies. Porting the test from the backport #18949 as it does not suffer from that issue and it points us directly to the issue.
|
enricocolasante
approved these changes
Oct 30, 2024
muilpp
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the fix for the issue came in
#18943
I tested it in part by asserting the /events/{uid} body is equal to /events?events={uid}. The test could hide a regression if we were to not return notes at all in both bodies.
Cherry-picking the assertion from the backport
#18949
as this test does not suffer from the above test issue and it points us directly to the root cause.