feat: add organisation overview page #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR created vs changelog branch (until that one is merged) |
amcgee
approved these changes
Dec 16, 2024
| by{' '} | ||
| <a | ||
| className={styles.link} | ||
| href={`/organisation/${organisationSlug}/view`} |
There was a problem hiding this comment.
Is it possible that organisationSlug will be null/undefined here leading to a broken link? Or is it guaranteed to always be populated by the backend?
There was a problem hiding this comment.
it is guaranteed to not be null/undefined, but the guarantee is happening at the application layer not the DB, there is no way that it could end up being null/undefined (we use slugify based on the name which is required) unless someone manually alters the DB ..
kabaros
force-pushed
the
feat/organisation-page
branch
from
a7f6bad to
2cc4de2
Compare
kabaros
force-pushed
the
feat/organisation-page
branch
from
2cc4de2 to
1a0826a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an organisation overview page, to support the page, it:
/organisation/:idto optionally include the appsA followup ticket will expose ability to filter by organisation to the app.
implements HUB-122.
apphub-organisation-page.webm