Move client to APworld #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: the pkgutil call seems to currently not be working, probably because the surrounding functions want a different format than bytes it returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
move client to apworld and removes core changes from branch
Note: the pkgutil call seems to currently not be working, probably because the surrounding functions want a different format than bytes it returnsshuffled the patch code around a bit to work with the format pkgutil.get_data returns
How was this tested?
packaged as an apworld and installed to my local frozen ap install, the client was added to my launcher, it opened fine,
but patching did not work perfectly (hence the above note)added and tested patching from apworld and had no issuesIf this makes graphical changes, please attach screenshots.