Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique id for each build #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcellus-trixus
Copy link

Hi,
I am not sure if you want this change in your project, but I needed this for my use case and thought you might find it useful.

It adds unique id to package directory name in packages directory, if "-unique_id" param is provided.
The implementation has a sideeffect that if the param is not provided it suffixes the name with ".", but I hope it will not be a problem.

Btw, this should solve issue #3, at least partially as the id is not based on a content hash thus is not deterministic.

@marcellus-trixus marcellus-trixus changed the title Custom app Unique id for each build Jan 30, 2019
@AlgorithmsAreCool
Copy link

@dgiagio Hey, do you think you will have any bandwidth to review this in the next few days or weeks?

Without this or something similar, deployed apps are un-upgradable as far as i can tell.

@cryy
Copy link

cryy commented Sep 2, 2019

any update to this? would love to have it instead of telling my users not to change the file name on a new version

@AlgorithmsAreCool
Copy link

@Cryyy I would give up on Warp :/
if you can, use the new single file publish feature in the dotnet sdk. It's officially supported and it works great (even for .net framework assemblies).

@lastlink
Copy link

lastlink commented Sep 4, 2019

@AlgorithmsAreCool I wrote a program in go to auto clear old versioned apps that were bundled using warp and dotnet core to compare versions from the warp exe app that I'd added from resource hacker and the dll version from dotnet core in the localapp warp folder.. My issue with the single bundle in dotnet core 3.0 is that I can't update the exe icon with resource hacker, but I can the bundled warp app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants