Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reentrancy-guard or complying with the CEI paradigm #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CARDIN00
Copy link

@CARDIN00 CARDIN00 commented Jan 10, 2025

Description

Integrations Checklist

  • Have any function signatures changed? If yes, outline below.
    The following functions are changed
    unzap Function
    zap Function

  • Have any features changed or been added? If yes, outline below.
    1;Added Reentrancy Protection:
    2;Validated Destination Addresses:

  • Have any events changed or been added? If yes, outline below.

  • Has all documentation been updated?

Changelog

Function Signature Changes

Features

1:Added Reentrancy Protection:
Ensured the function includes a nonReentrant modifier to safeguard against reentrant calls.

2:Validated Destination Addresses:
Added checks to validate that the recipient address is non-zero and expected.

3:Improved Ether Transfer Handling:
If Ether transfers occur in zap, the pull-over-push pattern would replace direct transfers.

Events

@CARDIN00
Copy link
Author

1:The nonReentrant modifier blocks potential reentrancy attacks during Ether transfers
2:Validation of Addresses, Prevents sending Ether to invalid or unintended addresses.
3:By adopting the pull-over-push pattern, Ether is transferred securely, and only intended recipients can withdraw funds.

@CARDIN00
Copy link
Author

Updated the Unzap function

@CARDIN00 CARDIN00 closed this Jan 12, 2025
@CARDIN00 CARDIN00 reopened this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant