Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support concurrent flows #9

Merged
merged 8 commits into from
May 2, 2024
Merged

Support concurrent flows #9

merged 8 commits into from
May 2, 2024

Conversation

lmuntaner
Copy link
Collaborator

Motivation

The main motivation is to allow the library to start multiple concurrent flows.

Changes

  • Store opened windows in a Map instead of one single instance.
  • Pass the flowId to the helper instead of creating it inside the helper.
  • Scope the flowId per handler so that each handler is about one flow.

Tests

  • Test that the function supports two concurrent flows.

@lmuntaner lmuntaner marked this pull request as ready for review April 30, 2024 13:15
frederikrothenberger
frederikrothenberger approved these changes May 2, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lmuntaner lmuntaner merged commit c3d3d24 into main May 2, 2024
6 checks passed
@lmuntaner lmuntaner deleted the lm-support-multiple-flows branch May 2, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger