Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license entry in package Cargo.toml #72

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add license entry in package Cargo.toml #72

merged 1 commit into from
Oct 29, 2024

Conversation

lmuntaner
Copy link
Collaborator

Motivation

Publishing to crates.io failed because of missing license.

Changes

  • Add license entry in the package Cargo.toml

Tests

  • I tried the publishing command with --dry-run and all tests passed.

Todos

  • Add entry to changelog (if necessary). NOT NECESSARY.

@lmuntaner lmuntaner requested a review from a team as a code owner October 29, 2024 13:04
@lmuntaner lmuntaner changed the title Add license Add license entry in package Cargo.toml Oct 29, 2024
@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger please review

frederikrothenberger
frederikrothenberger approved these changes Oct 29, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lmuntaner lmuntaner merged commit 7b54e04 into main Oct 29, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-publish-crates-io branch October 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger