Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci publish not finding script #58

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: ci publish not finding script #58

merged 1 commit into from
Sep 10, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Fix publish CI issue

Changes

  • The script publish-npm.sh find place in a parent folder now that we release from dist, so ../ instead of ./

@peterpeterparker peterpeterparker requested a review from a team as a code owner September 10, 2024 09:43
lmuntaner
lmuntaner approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner merged commit 922a047 into main Sep 10, 2024
8 checks passed
@lmuntaner lmuntaner deleted the fix/publish-ci branch September 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner