Fix nextJS issue #55
Closed
Fix nextJS issue #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterpeterparker what do you think of these changes. I'm a little bit disappointed I didn't find a better solution... |
|
We might not need it 👉 #48 (comment) Let's see... |
Good idea! Let's wait! |
|
We ultimately resolved the issue with #56. Therefore I guess we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is an issue with the JS library when the moduleResolution is set to
nodewhich happens in NextJS projects.The issue was raised here: #48
Changes
Tests
Tested that dummy-relying-party still builds with the changes.
Todos