chore(rust): Update ic-cdk to a non-yanked version #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
changed the title
|
The Cargo.lock isn't updated because it is not committed. The recommendation used to be: Commit the Cargo.lock for binaries, not for libraries. As of 2023 the picture is more nuanced, as it can sometimes make sense to commit the Cargo.lock for libraries. See: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ic-cdkversion 0.13 has been yanked. This causes problems for users ofverifiable-credentialstrying to pass a security audit.Changes
ic-cdkto0.15.Tests
See CI
Todos
Needed?