Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: agent-js peer dependency v2 #50

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

lmuntaner
Copy link
Collaborator

Motivation

If we bump agent-js in ic-js in our dapps, we also need to bump it in the verifiable-credentials.

@lmuntaner lmuntaner requested a review from a team as a code owner August 23, 2024 13:50
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@peterpeterparker
Copy link
Member

@lmuntaner agent-js v2.0.0 has been merged in ic-js main

@peterpeterparker peterpeterparker merged commit 79d8475 into main Aug 26, 2024
17 checks passed
@peterpeterparker peterpeterparker deleted the build/principal branch August 26, 2024 16:10
@peterpeterparker
Copy link
Member

I merge this as I need a next version in Oisy Wallet.

@lmuntaner
Copy link
Collaborator Author

@peterpeterparker did you do a new release of the js-library already?

@peterpeterparker
Copy link
Member

ic-js@next yes. I was considering whether we should propose a release of the dApps first before releasing ic-js, but I can also prepare the release of ic-js now. What do you prefer?

@lmuntaner
Copy link
Collaborator Author

I meant the npm library "@dfinity/verifiable-credentials". Don't you say you need it?

@peterpeterparker
Copy link
Member

Ah! Yes also next version only. Did so yesterday: https://github.com/dfinity/verifiable-credentials-sdk/actions/runs/10563242261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants