Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve implementation code for requestVerifiablePresentation #5

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Apr 25, 2024

Motivation

Clean up the code to make it more maintainable and readable.

Changes

  • Change implementation of requestVerifiablePresentation by using only one handler on the message event and a conditional logic inside.

Tests

  • Only one test needed changing and it makes sense because the expected error was inconsistent with the other error.

@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger please review when you have time.

It might be better to review the file on its own instead of the changes.

@lmuntaner lmuntaner changed the title Lm refactor code Improve code for requestVerifiablePresentation Apr 25, 2024
@lmuntaner lmuntaner changed the title Improve code for requestVerifiablePresentation Improve implementation code for requestVerifiablePresentation Apr 25, 2024
@lmuntaner lmuntaner marked this pull request as ready for review April 25, 2024 07:39
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks. Left only minor comments.

@lmuntaner lmuntaner merged commit f2c5c3b into main Apr 29, 2024
6 checks passed
@lmuntaner lmuntaner deleted the lm-refactor-code branch April 29, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants