Switch to published IC libraries #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the dependencies on the II and IC repositories (except for the `getrandom` hack). The only remaining non-published dependency is the the iota library fork, which I'm still working on and will be removed in a subsequent PR.
frederikrothenberger
force-pushed
the
frederik/switch-to-published-lib
branch
from
d1ed031 to
cb2a655
Compare
AntonioVentilii-DFINITY
approved these changes
Aug 19, 2024
| # II Dependencies | ||
| canister_sig_util.workspace = true | ||
| # unfortunately, there is a transitive dependency on getrandom which does _not_ compile to wasm unless we add this hacky workaround | ||
| ic-crypto-getrandom-for-wasm = { git="https://github.com/dfinity/ic", rev="faacac31032a9b98020475eb608fd63455603556" } |
There was a problem hiding this comment.
most probably already checked: this one shouldn't go into rust_packages Cargo file too?
There was a problem hiding this comment.
No, that is a hacky workaround that we only ever want in binary crates, because it clashes if included repeatedly. There is a ticket to clean this up with the crypto team: https://dfinity.atlassian.net/browse/CRP-2575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependencies on the II and IC repositories. The only remaining non-published dependency is the the iota library fork, which I'm still working on and will be removed in a subsequent PR.