Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: agent-js peer dependency v2 #47

Closed
wants to merge 1 commit into from
Closed

Conversation

peterpeterparker
Copy link
Member

Motivation

If we bump agent-js in ic-js in our dapps, we also need to bump it in the verifiable-credentials.

@peterpeterparker peterpeterparker requested a review from a team as a code owner August 5, 2024 06:33
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker
Copy link
Member Author

Forgot I already provided this PR.

ic-js is still on v1.4.0. NNS dapp should update the test suite to unlock the migration in our eco-system. We should maybe wait on it before merging this.

@lmuntaner
Copy link
Collaborator

Forgot I already provided this PR.

ic-js is still on v1.4.0. NNS dapp should update the test suite to unlock the migration in our eco-system. We should maybe wait on it before merging this.

NNS Dapp doesn't use this library (yet). Do they have a timeline when they will be on version 2?

@peterpeterparker
Copy link
Member Author

No timeline but, I'll need agent-js v2 for the signer standard so I monitor the topic closely.

@lmuntaner lmuntaner closed this Aug 23, 2024
@peterpeterparker peterpeterparker deleted the build/principal branch August 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants